-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for italic and bold fonts using attribute textStyle #179
base: master
Are you sure you want to change the base?
Conversation
…ead of skipping exception
…llPointerException anymore; + refactored redundant code passages
Cool, thanks for the PR. I'm not a massive fan of having to define bold/italic etc. It should just work with the textStyle attr. I'll mull this over when I have more time to spend on it. |
This is really cool, Thanks |
It's been 5 nice years developing apps for Android, natively, and every time I have to deal with bold/italic, I always end up with a lot of boilerplate code or juniors asking "why should I add Why don't we allow to define default fonts for different Typefaces and override them with It would make our lives really easier. |
@RafaRuiz My suggestion would be to move to the Calligraphy3 if that is something you still need or use the FontProviders in AndroidX now. |
My fault. |
When will this branch be merged? Because I'm also having the issue that I want to add multiple styles of a font. |
@basmaessen it won't be, this fork has no active dev. I would move to https://github.com/InflationX |
Thanks for this great project. It helped me a lot. Just one thing was missing. Support for bold and italic fonts depending on the attribute textStyle.
I forked gfranks' solution to use the native attribute textStyle for selecting bold/italic fonts.
There have been many redundancies. Therefore I refactored the changes. Additionally I fixed a bug because getTypeface() sometimes returns null.
It would be nice if you could integrate this solution. Let's just discuss about it.