Add GitHub authentication #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrisglein please review me! |
chrisglein
requested changes
Feb 15, 2019
Kanban4U/GitHub/GitHubLogic.cs
Outdated
|
|
||
| namespace Kanban4U | ||
| { | ||
| public static class GitHubLogic |
There was a problem hiding this comment.
I didn't pick that "Logic" name and I've been meaning to change it to something more specific sensible. Don't feel obligated to match the naming.
There was a problem hiding this comment.
I'm not, but couldn't think of another name. Do you have a suggestion?
Kanban4U/GitHub/GitHubLogic.cs
Outdated
| var settings = GlobalSettings.Instance; | ||
| if (settings.GitHubAccessToken == null) | ||
| { | ||
| settings.GitHubAccessToken = await GetGitHubAccessTokenWorker(); |
There was a problem hiding this comment.
Having the side effect of this makes this not feel like an honest "Get" method. "UpdateGitHubAccessToken" maybe?
chrisglein
approved these changes
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.