Fixing some buggy data handling, add some logging #17
+13
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm fixing a few things in this plugin:
SHOW ENGINE INNODB STATUS;
parsing code intry
/except
blocks. This change is a little on the blind side - we were seeing the plugin get unloaded with this in the collectd logs:The output from
SHOW ENGINE INNODB STATUS;
is a bit unpredictable and difficult to parse, so I'm making the assumption that defensive coding here is the way to go.2.
not 0
==True
, sonot value
will drop any values that are 0 on the floor. Check thatvalue
is not 0 before doing that return.3. Add a little more useful verbose logging.