Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: state goes back to preparing when didChangeDependencies called #169

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

chooyan-eng
Copy link
Owner

@chooyan-eng chooyan-eng commented Dec 10, 2024

Bug fixed that state goes back to PreparingCropEditorState when didChangeDependencies is called (e.g. when rebuild happens with different constraints) without initialize operation and never comes back to ReadyCropEditorState.

@chooyan-eng chooyan-eng self-assigned this Dec 10, 2024
@chooyan-eng chooyan-eng merged commit d83b0f9 into release/2.0.0 Dec 10, 2024
1 check passed
@chooyan-eng chooyan-eng deleted the fix/reset_state branch December 10, 2024 05:46
chooyan-eng added a commit that referenced this pull request Dec 12, 2024
* update pubspec.yaml

* update CHANGELOG.md for 2.0.0-dev.1

* udgrade dependency versions

* Feature/undo redo (#165)

* add: HistoryState class which manages history for undo/redo

* feat: undo/redo

* version up to 2.0.0-dev.2 including undo/redo feature

* add initialAspectRatio argument to Crop (#166)

* add initialAspectRatio argument to Crop

* refactor arguments to indicate initial crop rect

* version up to 2.0.0-dev.3

* some fixes (#167)

* fix: state goes back to preparing when didChangeDependencies called (#169)

* version up to 2.0.0-dev.4

* update to 2.0.0-dev.5

* Respect original format by default (#171)

* respect original format by default

* fix

* fix: respect initial size if specified when changing aspectRatio via controller (#170)

* fix: context disposed error (#172)

* fix: InvalidRectError (#173)

* fix: change errors not extends Error but implements Exception (#174)

* fix: typo (#175)

* version up to 2.0.0-dev.6

* rename suffix of error classes from Error to Exception

* fix: several bugs

* version up to 2.0.0-dev.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant