Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotdrinkvote 서버에서 fetch 하도록 변경 #188

Merged
merged 4 commits into from
Oct 17, 2023
Merged

hotdrinkvote 서버에서 fetch 하도록 변경 #188

merged 4 commits into from
Oct 17, 2023

Conversation

ksmfou98
Copy link
Contributor

📑 작업리스트

  • hotdrinkvote 서버에서 fetch 하도록 변경
  • 서버에서만 import 하는 모듈은 따로 분리

📘 리뷰노트

  • 참고 사항1

@vercel
Copy link

vercel bot commented Oct 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jurumarble ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 5:40am
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 5:40am

Base automatically changed from feature/add-module-css to develop October 17, 2023 05:39
@ksmfou98
Copy link
Contributor Author

@Leejha 배포 환경 테스트해보려고 선 머지 합니다 ~

@ksmfou98 ksmfou98 merged commit 5812fcb into develop Oct 17, 2023
2 checks passed
@ksmfou98 ksmfou98 deleted the feature/add-server-component-fetch branch October 17, 2023 05:40
Leejha
Leejha reviewed Oct 17, 2023
View reviewed changes
Copy link
Member

@Leejha Leejha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몇 api 파일에 fetch 사용한 코드 주석처리 되있어서 필요하면 주석 해제하고 사용하시면 돼요

apps/jurumarble/src/lib/env.ts
? `http://localhost:3000${Path.NAVER_LOGIN_PROCESS}`
: `${CLIENT_URL}${Path.NAVER_LOGIN_PROCESS}`;

export const DATA_GO_API_KEY = process.env.NEXT_PUBLIC_DATA_GO_API_KEY || "";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 파일 분리 좋은 것 같습니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leejha Leejha Leejha left review comments

@leejiho9898 leejiho9898 Awaiting requested review from leejiho9898

Assignees

@ksmfou98 ksmfou98

Labels
dependencies JURUMARBLE 🙏리뷰해주세요
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksmfou98 @Leejha