rename M_HLVX to prevent clashing with M_FLUSH #3335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change: bug report
Impact: no functional change
Development Phase: implementation
Release Notes
Renamed the constant M_HLVX from
10000
to11000
to prevent clashing with M_FLUSH, asisRead
would always return true for memory commands withM_FLUSH
.Note: The bug was spotted while working with
boom/src/main/scala/lsu/dcache.scala
of the BOOM. This preventsM_FLUSH
commands from sending a response ass2_send_resp
would always evaluate to false.