Feat: Allow anonymous dependency #200
Merged
+55
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chickenandpork
force-pushed
the
feat/allow-anonymous-dependency
branch
from
f6e5b82 to
6911a89
Compare
chickenandpork
force-pushed
the
feat/allow-anonymous-dependency
branch
from
6911a89 to
ad36f88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces a macro with a formal rule to unblock "anonymous dependency", which is (I think) the name for when the BCR does an import such as:
Since macros are evaluated where used, the defaults for functions are strings in the context of where they are used, and the previous
@rules_synology//tools:resizewas wreaking havoc.I should be able to re-enable a
bcr_test_modulein thepresubmit.ymlafter this.