chore: delete MODULE.bazel.lock files: so broken and misleading #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a bit concerned about the plan to go to JavaScript kitchen-sink lock files.
Seriously, what happened to checksums/signatures committed to our repos, so we have clear visibility that they didn't change?
Version-tracking the
MODULE.bazel.lock
fails: it seems we can delete dependencies but they stick around in the lock files, and are not removed such that a later build seems to pass with some direct dependencies no longer states in theMODULE.bazel file
We used to have two strong benefits form Bazel:
I'd been chewing through issues of deleted direct dependencies that happily passed CI build. Coincidentally, they still had mention in
MODULE.bazel.lock
of the resources deleted fromMODULE.bazel
. How can that be a good thing?So frustrated right now. the massive churn-baby-churn lock files seem only half-baked. I didn't like
package.json
lock files before, so I'm a bit biased by this copy-pasta innovation, but this seems really unsafe right now.KILL IT WITH FIRE (for now)