Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dict): implement CDB based user dictionary #422

Merged
merged 16 commits into from
Jan 6, 2024
Merged

Conversation

kanru
Copy link
Member

@kanru kanru commented Jan 2, 2024

In preparation to replace hash.txt and hash.dat when sqlite is not needed.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 166 lines in your changes are missing coverage. Please review.

Comparison is base (bb05466) 79.94% compared to head (e522392) 79.83%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/dictionary/cdb.rs 58.27% 63 Missing ⚠️
src/dictionary/trie.rs 17.77% 37 Missing ⚠️
src/dictionary/kv.rs 87.55% 27 Missing ⚠️
src/dictionary/mod.rs 16.66% 25 Missing ⚠️
src/editor/estimate.rs 61.53% 5 Missing ⚠️
src/zhuyin/syllable.rs 75.00% 3 Missing ⚠️
src/conversion/mod.rs 88.23% 2 Missing ⚠️
src/dictionary/layered.rs 95.74% 2 Missing ⚠️
src/dictionary/sqlite.rs 96.66% 1 Missing ⚠️
src/editor/selection/symbol.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   79.94%   79.83%   -0.11%     
==========================================
  Files          55       59       +4     
  Lines       10535    11398     +863     
==========================================
+ Hits         8422     9100     +678     
- Misses       2113     2298     +185     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanru kanru force-pushed the rust/cdb-userphrase branch from a42617e to 23d5587 Compare January 3, 2024 10:57
@kanru kanru force-pushed the rust/cdb-userphrase branch from af1cd66 to aa9567c Compare January 3, 2024 13:42
@kanru kanru force-pushed the rust/cdb-userphrase branch from 6afc047 to b8140a6 Compare January 6, 2024 01:43
@kanru kanru force-pushed the rust/cdb-userphrase branch from 8cd280e to 9058c0d Compare January 6, 2024 02:21
@kanru kanru added this to the v0.6.0 milestone Jan 6, 2024
@kanru kanru marked this pull request as ready for review January 6, 2024 15:11
@kanru kanru merged commit 080b261 into master Jan 6, 2024
18 of 20 checks passed
@kanru kanru deleted the rust/cdb-userphrase branch January 6, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant