Skip to content

Commit

Permalink
tools: use os home dir to instead of the hardcoded PATH (tendermint#9444
Browse files Browse the repository at this point in the history
)

porting PR tendermint#6498 to main

#### PR checklist

- [x] Tests written/updated, or no tests needed
- [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed
- [x] Updated relevant documentation (`docs/`) and code comments, or no
      documentation updates needed
  • Loading branch information
JayT106 authored Sep 23, 2022
1 parent 5fe1a72 commit e8ec611
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG_PENDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
- Data Storage
- [state] \#6541 Move pruneBlocks from consensus/state to state/execution. (@JayT106)

- Tooling
- [tools/tm-signer-harness] \#6498 Set OS home dir to instead of the hardcoded PATH. (@JayT106)

### FEATURES

### IMPROVEMENTS
Expand Down
2 changes: 1 addition & 1 deletion tools/tm-signer-harness/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
TENDERMINT_VERSION?=latest
BUILD_TAGS?='tendermint'
VERSION := $(shell git describe --always)
BUILD_FLAGS = -ldflags "-X github.com/tendermint/tendermint/version.TMCoreSemVer=$(VERSION)
BUILD_FLAGS = -ldflags "-X github.com/tendermint/tendermint/version.TMCoreSemVer=$(VERSION)"

.DEFAULT_GOAL := build

Expand Down
2 changes: 1 addition & 1 deletion tools/tm-signer-harness/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import (
const (
defaultAcceptRetries = 100
defaultBindAddr = "tcp://127.0.0.1:0"
defaultTMHome = "~/.tendermint"
defaultAcceptDeadline = 1
defaultConnDeadline = 3
defaultExtractKeyOutput = "./signing.key"
Expand Down Expand Up @@ -59,6 +58,7 @@ Use "tm-signer-harness help <command>" for more information about that command.`
fmt.Println("")
}

defaultTMHome := internal.ExpandPath("~/.tendermint")
runCmd = flag.NewFlagSet("run", flag.ExitOnError)
runCmd.IntVar(&flagAcceptRetries,
"accept-retries",
Expand Down

0 comments on commit e8ec611

Please sign in to comment.