New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix starving caused by GIL #289

Merged

auxten merged 2 commits into main from patchset-2.2.0b1

Dec 12, 2024

+147 −3

Member

auxten commented Dec 9, 2024 •

edited

Loading

Fix starving caused by GIL

Calling isInheritsFromPyReader()(Need acquire GIL) from Chunk PythonSource::generate() will cause hard to re-produce deadlock. The Python thread might already hold GIL, and waiting for ClickHouse engine returning data, but the pipeline running is also wait for GIL💥
We should doing everything require GIL before the pipeline start!

auxten added 2 commits

December 9, 2024 06:35


          Fix starving caused by GIL

d2f938f


          Add mini clickbench for dataframe

09da2d5

auxten merged commit 01afb91 into main

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet