Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rubric score persistance #5052

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Rubric score persistance #5052

wants to merge 3 commits into from

Conversation

valentinludu
Copy link
Collaborator

@valentinludu valentinludu commented Nov 21, 2024 •
edited
Loading

Card

This PR improves and adds the possibility to:

  • save rubic answers in session storage

And fixes:

  • a prop object containing a "key" prop is being spread into JSX
  • disabled prop of a button received a string instead of a boolean
  • element can't have ref. Add a forwardRef to your component

(The fixes can be seen in each commit)

@mattcasey mattcasey added the 🚀 deploy Deploy main webapp to staging label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🚀 deploy Deploy main webapp to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentinludu @mattcasey