Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add -R shorthand to --role #405

Merged
merged 2 commits into from
Dec 18, 2024
Merged

feat: add -R shorthand to --role #405

merged 2 commits into from
Dec 18, 2024

Conversation

gy-mate
Copy link
Contributor

@gy-mate gy-mate commented Dec 14, 2024

Fixes #299.

I hope that there are no other parts in the code that should be changed.

To test the change:

mods -R default "What's up?"
  1. Run this on the main branch version. This should give the following error:
    Check out  mods -h  for help.
    
    unknown shorthand flag: 'R' in -R%!(EXTRA string=  )
    
  2. Run this on my branch. This should give no errors.

@gy-mate gy-mate marked this pull request as ready for review December 14, 2024 19:15
@gy-mate gy-mate requested a review from caarlos0 as a code owner December 14, 2024 19:15
main.go Outdated Show resolved Hide resolved
@caarlos0
Copy link
Member

thanks for the pr! just one comment though :)

Co-authored-by: Carlos Alexandro Becker <[email protected]>
@gy-mate
Copy link
Contributor Author

gy-mate commented Dec 16, 2024

@caarlos0 Thanks for the review—my bad! :)

@gy-mate gy-mate requested a review from caarlos0 December 16, 2024 18:57
@caarlos0 caarlos0 merged commit b7e6af6 into charmbracelet:main Dec 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request "-R" short code flag for "--role" , please?
2 participants