feat: have --quiet supress all stderr messages for success #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, according to the README, --quiet should supress all stderr output, which was incorrect. It did what the help says: supress only the spinner. This commit makes --quiet supress all "superflous" stderr ouput, meaning both the spinner and messages that confirm an operation was carried out successfully like "Conversation saved...". Rationale: for scriptability, it would be nice to be able to supress non-error stderr messages without losing the ability to see the error when something actually goes wrong. Maybe this isn't the way to do it though, and there should be options for --no-spinner, --quiet (supress all stderr) and --shy (what this commit implements).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, according to the README,
--quietshould supress all stderr output, which was incorrect. It did what the help says: supress only the spinner.This commit makes
--quietsupress all "superflous" stderr ouput, meaning both the spinner and messages that confirm an operation was carried out successfully like "Conversation saved...".Rationale: for scriptability, it would be nice to be able to supress non-error stderr messages without losing the ability to see the error when something actually goes wrong.
Maybe this isn't the way to do it though, and there should be options for
--no-spinner,--quiet(supress all stderr) and--shy(what this commit implements).