feat(tree): hide children #454
Open
+196
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Alexandro Becker <[email protected]>
caarlos0
approved these changes
Dec 10, 2024
aymanbagabas
approved these changes
Dec 10, 2024
|
Another thing to improve this PR: have an example hiding both ways with comments on why you would use Hide vs SetHidden. It already says in their go doc, but could be handy to show how they differ in usage. |
|
SetValue for tree does the same thing as Root. Should I mention any difference in the docs? Root can be used during or after creation, SetValue can be used after creation |
caarlos0
reviewed
Dec 12, 2024
caarlos0
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the godoc of tree to match capitalization used for leaf while I was at it