fix!: style size to include borders #451
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
changed the title
bashbunni
commented
Dec 2, 2024
| Height(8). | ||
| Width(columnWidth + 1) |
There was a problem hiding this comment.
we don't need to do this anymore because the +1 before was to account for the border on one side
bashbunni
commented
Dec 2, 2024
| @@ -282,7 +281,7 @@ func main() { | |||
| listItem("Pomelo"), | |||
| ), | |||
| ), | |||
| list.Width(columnWidth).Render( | |||
There was a problem hiding this comment.
all columns have the same width now
|
@meowgorithm Should this change be part of v2 given it may break some layouts? This change causes a lot of existing examples to be off by 1 or two depending on if the border is only on one side or not. Authors are currently working around by having That makes this change breaking despite it being the intended behaviour for edit: Will include this in v2 since it is breaking |
bashbunni
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
included tests for these changes that fail on
masterbut pass on this branch :)