-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrapping and height calculations #485
Draft
bashbunni
wants to merge
22
commits into
main
Choose a base branch
from
wrap-group-scope
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 20 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
ea80025
feat: set group with from size msg
bashbunni a748847
feat: handle WindowSizeMsg + base height on rendered content
bashbunni 152c087
feat: render prefix before newlines
bashbunni ae0674b
feat: update viewport on resize, cursor != height so no scroll...
bashbunni c586d40
fix: always update viewport height
bashbunni 18a0ca9
fix: add option prefix
bashbunni d206fc6
fix(multiselect): width calculation
bashbunni b41c5e7
fix: calculate offset from previous field heights
bashbunni 98f01b6
feat: add calculate wrapping helper
bashbunni ea01c18
fix(select): wrap select field
bashbunni 262ac14
feat: make group set field widths accounting for styles
bashbunni 4ff8255
feat: set width
bashbunni c5e8fb8
feat: stack buttons in narrow window
bashbunni b1e6469
feat: add Theme function to Fields
bashbunni ec82a9b
feat: calculate width based on field theme
bashbunni 75664f1
fix(group): fix height calculation
bashbunni 70db481
feat: remove FullWidth helper (not needed)
bashbunni c9016a4
fix(group): fix off by one at top for overflowed content
bashbunni 5164a77
fix(group): add gap height to calculations
bashbunni 682d2c7
fix: don't wrap inline content
bashbunni f8b3922
Revert "fix: calculate offset from previous field heights"
bashbunni d5b26eb
Merge branch 'main' into wrap-group-scope
bashbunni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels a bit better I think 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so true, I can update this for all fields