Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(choose): label delimiters #783

Merged
merged 1 commit into from
Dec 17, 2024
Merged

feat(choose): label delimiters #783

merged 1 commit into from
Dec 17, 2024

Conversation

caarlos0
Copy link
Member

I'm not sure if I like this impl, but it does work.

closes #406

@caarlos0
feat(choose): label delimiters
b0374a3 
I'm not sure if I like this impl, but it does work.

closes #406
@meowgorithm
Copy link
Member

What does it look like on the CLI?

@caarlos0
Copy link
Member Author

like this:

CleanShot 2024-12-16 at 16 53 24@2x
CleanShot 2024-12-16 at 16 53 45@2x

@meowgorithm
Copy link
Member

I think it's good. This also works as expected:

$ printf 'A:a\nB:b\nC:c\n' | go run . choose --label-delimiter=':'

@caarlos0 caarlos0 merged commit 2e321f5 into main Dec 17, 2024
14 checks passed
@caarlos0 caarlos0 deleted the choose-labels branch December 17, 2024 12:47
@caarlos0 caarlos0 mentioned this pull request Dec 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowgorithm meowgorithm meowgorithm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gum choose mapped/masked/labeled values
2 participants
@caarlos0 @meowgorithm