feat: add --[no-]strip-ansi-codes option #782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #739, #188 (comment)
I chose to hide the conditional behind an interface to simplify the call sites and duplication of flag processing across commands. If we add further stdin-related options in the future, this would become more useful, as more logic would be abstracted away. However, I can see the argument against this approach; this pattern isn't used in the rest of the codebase (from what I saw), and adding it for such a small feature might not be worth the added complexity. In that case, it would be pretty easy to get rid of the interface and just inline the conditional in every command.