Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: yes|gum confirm #772

Merged
merged 3 commits into from
Dec 17, 2024
Merged

feat: yes|gum confirm #772

merged 3 commits into from
Dec 17, 2024

Conversation

caarlos0
Copy link
Member

refs #491

@caarlos0
feat: yes|gum confirm
0b53eef 
Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0 caarlos0 self-assigned this Dec 12, 2024
@bashbunni
Copy link
Member

Do we just need yes or support for no as well? Works great as-is for yes | gum confirm (tried various uppercase & lowercase combos of 'YES', all worked great)

@caarlos0
Copy link
Member Author

@bashbunni no would be anything that isn't yes 🤔

@caarlos0 caarlos0 merged commit 0b89ff8 into main Dec 17, 2024
14 checks passed
@caarlos0 caarlos0 deleted the confirm-yes branch December 17, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymanbagabas aymanbagabas aymanbagabas approved these changes

Assignees

@caarlos0 caarlos0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caarlos0 @bashbunni @aymanbagabas