Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: esc exit 1, ctrl+c exit 130, help arrow order #771

Merged
merged 1 commit into from
Dec 12, 2024
Merged

feat: esc exit 1, ctrl+c exit 130, help arrow order #771

merged 1 commit into from
Dec 12, 2024

Conversation

caarlos0
Copy link
Member

Some standards:

  • Esc exits 1
  • CTRL+C exits 130 (interrupt)
  • Help arrows are always in HJKL order

closes #138

@caarlos0
feat(choose,confirm,file,filter,input,table,write): esc exit 1, ctrl+…
81ab787 
…c exit 130, help arrow order

Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0 caarlos0 self-assigned this Dec 11, 2024
@caarlos0 caarlos0 merged commit 774667a into main Dec 12, 2024
14 checks passed
@caarlos0 caarlos0 deleted the esc-quit branch December 12, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymanbagabas aymanbagabas aymanbagabas approved these changes

Assignees

@caarlos0 caarlos0

Labels
cmd/choose cmd/confirm cmd/file cmd/filter cmd/input cmd/table cmd/write enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return a different error code for ESC vs CTRL-C in filter
2 participants
@caarlos0 @aymanbagabas