Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: using xpty #151

Merged
merged 5 commits into from
Dec 18, 2024
Merged

fix: using xpty #151

merged 5 commits into from
Dec 18, 2024

Conversation

caarlos0
Copy link
Member

using x/xpty, and using term size as pty size

@caarlos0
fix: using xpty
e3cfc0c 
Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0 caarlos0 added the enhancement New feature or request label Nov 20, 2024
bashbunni
bashbunni approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@bashbunni bashbunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass + tried

  • -x "git status"
  • main.go -o main.png
  • main.go -o main.svg

all worked as expected

aymanbagabas
aymanbagabas reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@aymanbagabas aymanbagabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

go.mod Outdated Show resolved Hide resolved
@bashbunni
Copy link
Member

Need to update deps, then good to merge :)

@caarlos0 caarlos0 merged commit ead86fa into main Dec 18, 2024
13 checks passed
@caarlos0 caarlos0 deleted the pty branch December 18, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymanbagabas aymanbagabas aymanbagabas left review comments

@bashbunni bashbunni bashbunni approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caarlos0 @bashbunni @aymanbagabas