(v2) feat: add WithRequestBackground option to query terminal background c… #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olor This commit adds a new option to the program, `WithRequestBackground`, which will send a request to the terminal to query the background color of the terminal.
caarlos0
approved these changes
Oct 28, 2024
aymanbagabas
changed the title
|
I don't think this option makes sense, as it would create two different workflows to request the background color, one through calling |
|
I think I agree. Leaving it in the model's init function makes more clear that is a dependency of that model, and the flow is also clearer I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…olor
This commit adds a new option to the program,
WithRequestBackground, which will send a request to the terminal to query the background color of the terminal.