Skip to content

Commit

Permalink
Add requirements.txt to sdist, remove README.md from data_files
Browse files Browse the repository at this point in the history
Fixes rom1504#47.

- `requirements.txt` being missing from the source tarball meant that this package was only possible to install from the wheel, not from the sdist; one can reproduce the problem by using `--no-binary :all:` as an argument to `pip`.
- Adding `README.md` to `data_files` meant that it was installed into site-packages instead of only being added to the source tarball; being at the root, it conflicted with any _other_ Python package trying to install a README.md when using a package manager that tracks such conflicts.
  • Loading branch information
charles-dyfis-net committed Jan 23, 2024
1 parent af97bd8 commit 3809e2b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions MANIFEST.in
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
include README.md requirements.txt
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ def _read_reqs(relpath):
author="Romain Beaumont",
author_email="[email protected]",
url="https://github.com/rom1504/embedding-reader",
data_files=[(".", ["README.md"])],
keywords=["machine learning"],
install_requires=REQUIREMENTS,
classifiers=[
Expand Down

0 comments on commit 3809e2b

Please sign in to comment.