Skip to content

Commit

Permalink
Merge pull request #245 from chaoticgd/minor_corrections
Browse files Browse the repository at this point in the history
Make some minor corrections to comments, documentation, and formatting
  • Loading branch information
chaoticgd authored Sep 18, 2024
2 parents bb98913 + 916473c commit 0870d62
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## v2.2

- Provide x64 builds for macOS again in addition to the arm64 builds.
- Mac builds compiled for x64 processors are now provided in addition to the arm64 builds.
- stdump: The `functions` and `globals` subcommands now output a header comment like the `types` command.
- stdump: The output format of the `files` subcommand has been updated.

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ A library and set of command line tools for parsing debugging symbols from PS2 g

### demangle

Demangler for the old GNU ABI.
C++ symbol demangler with support for both the new Itanium C++ ABI (GCC 3+) mangling scheme and the old GCC 2 scheme.

### objdump

Expand Down
2 changes: 1 addition & 1 deletion src/ccc/mdebug_importer.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
namespace ccc::mdebug {

// Perform all the main analysis passes on the mdebug symbol table and convert
// it to a set of C++ ASTs.
// it to a set of symbols and C++ ASTs.
Result<void> import_symbol_table(
SymbolDatabase& database,
std::span<const u8> elf,
Expand Down
2 changes: 1 addition & 1 deletion src/ccc/symbol_database.h
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ class LocalVariable : public Symbol {
static constexpr u32 FLAGS = WITH_ADDRESS_MAP;

LocalVariableHandle handle() const { return m_handle; }
FunctionHandle function() const { return m_function; };
FunctionHandle function() const { return m_function; }

std::variant<GlobalStorage, RegisterStorage, StackStorage> storage;
AddressRange live_range;
Expand Down
6 changes: 3 additions & 3 deletions src/ccc/symbol_table.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
namespace ccc {

const std::vector<SymbolTableFormatInfo> SYMBOL_TABLE_FORMATS = {
{MDEBUG, "mdebug", ".mdebug"}, // The infamous Third Eye symbol table.
{SYMTAB, "symtab", ".symtab"}, // The standard ELF symbol table.
{SNDLL, "sndll", ".sndata"} // The SNDLL symbol table.
{MDEBUG, "mdebug", ".mdebug"},
{SYMTAB, "symtab", ".symtab"},
{SNDLL, "sndll", ".sndata"}
};

const SymbolTableFormatInfo* symbol_table_format_from_enum(SymbolTableFormat format)
Expand Down
6 changes: 3 additions & 3 deletions src/ccc/symbol_table.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ namespace ccc {
// Determine which symbol tables are present in a given file.

enum SymbolTableFormat {
MDEBUG = 0, // The infamous Third Eye symbol table
SYMTAB = 1, // Standard ELF symbol table
SNDLL = 2 // SNDLL section
MDEBUG = 0, // The infamous Third Eye symbol table.
SYMTAB = 1, // Standard ELF symbol table.
SNDLL = 2 // SNDLL dynamic linker symbol table.
};

struct SymbolTableFormatInfo {
Expand Down

0 comments on commit 0870d62

Please sign in to comment.