-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored Graal Backends using Strategy Pattern #108
Open
wmeijer221
wants to merge
9
commits into
chaoss:master
Choose a base branch
from
Groninger-Bugbusters:refac/signed-off
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit a90d309 Author: Willem Meijer <[email protected]> Date: Thu Jan 27 10:01:16 2022 +0100 minor refactor commit d61d875 Merge: 54003a3 dc0657b Author: Willem Meijer <[email protected]> Date: Thu Jan 27 09:46:03 2022 +0100 Merge pull request #10 from Groninger-Bugbusters/refac/codep-coqua Refactor CoDep and CoQua and their analyzers commit dc0657b Merge: 360b497 54003a3 Author: Willem Meijer <[email protected]> Date: Thu Jan 27 09:45:55 2022 +0100 Merge branch 'refac/complete' into refac/codep-coqua commit 54003a3 Merge: fa85875 5bad55b Author: Willem Meijer <[email protected]> Date: Thu Jan 27 09:44:16 2022 +0100 Merge pull request #9 from Groninger-Bugbusters/refac/covuln Refactor CoVuln commit 5bad55b Merge: 827816e fa85875 Author: Willem Meijer <[email protected]> Date: Thu Jan 27 09:44:04 2022 +0100 Merge branch 'refac/complete' into refac/covuln commit fa85875 Merge: 7572257 0b57573 Author: Willem Meijer <[email protected]> Date: Thu Jan 27 09:38:08 2022 +0100 Merge pull request #8 from Groninger-Bugbusters/refac/colic-colang commit 360b497 Author: Erwin de Haan <[email protected]> Date: Wed Jan 26 17:06:40 2022 +0100 Updated docstrings commit 827816e Author: Leon Visscher <[email protected]> Date: Wed Jan 26 17:03:43 2022 +0100 Update covuln.py version commit 63db6ea Author: Erwin de Haan <[email protected]> Date: Wed Jan 26 16:49:58 2022 +0100 Increase version numbers commit ff19bac Author: Erwin de Haan <[email protected]> Date: Wed Jan 26 15:46:50 2022 +0100 Refactor CoDep and CoQua and their analyzers commit 644b5bd Author: Leon Visscher <[email protected]> Date: Wed Jan 26 15:07:50 2022 +0100 Refactor CoVuln commit 0b57573 Author: Willem Meijer <[email protected]> Date: Wed Jan 26 14:21:25 2022 +0100 Refactor CoCom + CoLang altered version release bandit version cap bandit 1.7.2 no longer supports python 3.6 added new packages to setup.py added bandit version cap in setup.py removed trailing whitespace removed trailing whitespace Signed-off-by: Willem Meijer <[email protected]> Signed-off-by: Leon Visscher <[email protected]> Signed-off-by: Erwin de Haan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graal backends face evolution issues. This refactor implements the strategy pattern in the Graal backends to prevent these issues from occurring. These issues were initially pointed out in #89, we introduced our proposed solution in #104, and made a PR earlier for only the CoLic backend in #107.
This PR implements a complete refactor of the Graal backends. Because the commits have to be signed off and we didn't do that during development, this branch has (almost) all changes squashed.
To split up the work in chunks, we recommend checking out these PRs: PR CoLic, PR CoVuln, PR CoCom + CoLang, PR Codep + CoQua. We combined the PR for some backends, as some of them use the same analyzers.
Note that the changes in #107 are included in this PR as well (including the CI fix), so if this PR is approved and merged, there's no need to review/merge that one. On top of that, it probably wouldn't do the project much good if only #107 is merged.