Shutdown cleanup #98
Merged
Shutdown cleanup #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bjornaxis - the fix is much appreciated! I hope to have time to review soon. I will have to refresh my memory on code I haven't looked at in a long time. Meanwhile, would you mind opening an issue on the crashes and provide any info you may have that would help me reproduce it? If you have any stack traces or other clues that would also be great to have. Note that CI being stuck is probably due to the ubuntu-18.04 runner not being available anymore on github (will fix). |
|
Hi,
I have created issue #99 and tried to explain what is happening on a
higher level (and how to increase chances of provoking the error).
The errors I see is mostly asserts in liblsd/hash.c or normal segfaults.
Since this is a file-server and I access a lot of data to provoke it to
crash I am not sure if I can share any crash dumps since I do not know
what else could be in there (sorry).
/BA
|
added 4 commits
December 29, 2024 07:45
Once refcount reaches zero the conn data could be deallocated and then the refcond is not valid anymore. So always signal on this under the lock to avoid this race.
Do the cleanup of the connection thread in a callback function so we can cancel the thread using pthread_cancel().
The connection thread is detached so we cannot join it to wait for its compleation on shutdown. Use the conncount in server to keep track of when all connection threads have actually finished. To keep this safe we must wait to update this value until the thread has done all of its cleanup.
The conection threads are using the resources that are deallocated in the main diod thread. If they are not shut down cleanly before this deallocation we could get craches at shutdown due to this.
garlick
force-pushed
the
shutdown_cleanup
branch
from
893789f to
2b03061
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We have had problems with diod crashing during shutdown and found out that there are races between thread shutdown and data deallocations.
I have made some patches here that I think solves it (at least we cannot trigger the crashes anymore).