-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cellxgene-schema must update validation for X (Matrix Layers) #1099
Comments
For this requirement:
Is this simply a check in the matrix dimensions? How else would we know that the matrix is or is not |
When might a cell in a matrix have MORE than one value?
|
The "Cell" in this context refers to a biological cell; each row in our matrix represents a cell from our obs dataframe (and each col is a gene). Therefore, we must check that each row in our matrix has at least one non-zero value (that is, ensure each cell has at least one gene with a gene expression value > 0) |
Thanks @nayib-jose-gloria , I was thinking of a cell as in a column/row pair in a 2D matrix. This makes a ton of sense! |
correct, all our validator can do is enforce the right matrix dimensions. the rest is instructions for a curator/submitter to do manually |
Changelog
X (Matrix Layers)
Design
numpy.float32
.If
uns['spatial']['is_single']
isFalse
then each cell MUST contain at least one non-zero value.If
uns['spatial']['is_single']
isTrue
then the unfiltered feature-barcode matrix (raw_feature_bc_matrix
) MUST be used. See Space Ranger Feature-Barcode Matrices.if
assay_ontology_term_id
is"EFO:0022860"
for Visium CytAssist Spatial Gene Expression, 11mm, this matrix MUST contain 14336 rows; otherwise, this matrix MUST contain 4992 rows.If the
obs['in_tissue']
value is1
, then the cell MUST contain at least one non-zero value. If anyobs['in_tissue']
values are0
, then at least one cell corresponding to aobs['in_tissue']
with a value of0
MUST contain a non-zero value.AnnData.raw.X
unless no "normalized" is provided, thenAnnData.X
AnnData.X
The text was updated successfully, but these errors were encountered: