chore: Fix compatibility tests #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2685 +/- ##
=======================================
Coverage 70.52% 70.52%
=======================================
Files 96 96
Lines 6652 6654 +2
Branches 769 769
=======================================
+ Hits 4691 4693 +2
Misses 1885 1885
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kaloster
force-pushed
the
thuang-fix-compatibility-tests
branch
3 times, most recently
from
1cd18ab
to
9479c06
Compare
kaloster
force-pushed
the
thuang-fix-compatibility-tests
branch
2 times, most recently
from
0b061de
to
912f506
Compare
|
all green now - verified to install and run locally 
|
tihuan
commented
Sep 3, 2024
| @@ -0,0 +1 @@ | |||
| 16.20.0 | |||
kaloster
force-pushed
the
thuang-fix-compatibility-tests
branch
from
912f506
to
5233024
Compare
kaloster
force-pushed
the
thuang-fix-compatibility-tests
branch
2 times, most recently
from
fb896c7
to
bd1d302
Compare
kaloster
force-pushed
the
thuang-fix-compatibility-tests
branch
from
bd1d302
to
15ed541
Compare
tihuan
commented
Sep 4, 2024
kaloster
force-pushed
the
thuang-fix-compatibility-tests
branch
from
15ed541
to
eca5d20
Compare
|
V COOL!! LGTM 🎉🎉🎉 Thank you thank you!! |
|
@kaloster I think you need to LGTM this PR to merge lol Sorry ahahah |
kaloster
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
pupetteerandjest-pupetteerAs for Python 3.12 - it requires updating flatbuffers in order to work which is a breaking change and doesn't work with the current dep tree - it will also require migration