Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontport: cxg dataset (TileDb) from single-cell-explorer to Annotate v1.2.0 #2656

Closed
wants to merge 2 commits into from

Conversation

Neah-Ko
Copy link

@Neah-Ko Neah-Ko commented Jan 19, 2024

… v1.2.0
Issue: #2655

Reviewers

Functional:
Readability:

@MaximilianLombardo

Changes

  • add
    • CXG dataset: A tiledb compliant format that used to be present on this repo until ~v0.17 or so, and is still the backend of single-cell-explorer product
      • Includes all the necessary code for this feature, with gentle attempts at refactoring
      • conversion class from H5AD to CXG taken from cellxgene@b3aadf6632b5a32d91f47d2777ec4b4c0565c7dd (v0.16.3)
      • CXG dataset code merged from single-cell-explorer repository
  • remove
    • Nothing
  • modify
    • Slight tweaks on server/data_common/{matrix_loader,data_adaptor}.py to account for joint compatibility
    • Add entries in the Makefile to build a wheel
    • client/package-lock.json -> regenerated with npm v9.6.7 , node v18.17.1, as my docker builds are often complaining about it being obsolete and fetching metadata at each install

@MaximilianLombardo
Copy link

Thanks @Neah-Ko ! We appreciate the time and effort in writing the PR; as mentioned previously, we currently have no resources to review the PR and bring it into production, and we will reach back out when/if we have resources available to discuss any next steps.

Copy link

github-actions bot commented Feb 6, 2024

This PR has not seen any activity in the past 2 weeks; if no one comments or reviews it in the next 3 days, this PR will be closed.

@github-actions github-actions bot added the stale label Feb 6, 2024
Copy link

This PR was closed because it has been inactive for 17 days, 3 days since being marked as stale. Please re-open if you still need this to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants