headless + args

chanzuckerberg · Sep 10, 2024 · 645d079 · 645d079
1 parent 2102768
commit 645d079
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/.github/workflows/compatibility_tests.yml b/.github/workflows/compatibility_tests.yml
@@ -82,12 +82,9 @@ jobs:
         run: |
           sudo apt-get update
           sudo apt-get install -y libhdf5-serial-dev
-          sudo apt-get install chromium-browser
       - name: Install dependencies (MacOS)
         if: startsWith(matrix.os, 'macos')
-        run: |
-          brew install --cask chromium
-          brew install hdf5
+        run: brew install hdf5
       - name: Install cellxgene from `main` branch
         if: matrix.cellxgene_build == 'main'
         run: |

diff --git a/.github/workflows/push_tests.yml b/.github/workflows/push_tests.yml
@@ -99,7 +99,6 @@ jobs:
             ${{ runner.os }}-node-
       - name: Install dependencies
         run: |
-          brew install --cask chromium
           pip install setuptools
           make pydist install-dist
       - name: Smoke tests (without annotations feature)

diff --git a/client/jest-puppeteer.config.js b/client/jest-puppeteer.config.js
@@ -7,12 +7,17 @@
 const ENV_DEFAULT = require("../environment.default.json");
 
 const jestEnv = process.env.JEST_ENV || ENV_DEFAULT.JEST_ENV;
-const isHeadful =
-  process.env.HEADFUL === "true" || process.env.HEADLESS === "false";
+// const isHeadful =
+//   process.env.HEADFUL === "true" || process.env.HEADLESS === "false";
 
 const DEFAULT_LAUNCH_CONFIG = {
-  headless: !isHeadful,
-  args: ["--ignore-certificate-errors", "--ignore-ssl-errors"],
+  headless: true,
+  args: [
+    "--ignore-certificate-errors",
+    "--ignore-ssl-errors",
+    "--no-sandbox",
+    "--disable-setuid-sandbox",
+  ],
   ignoreHTTPSErrors: true,
   defaultViewport: {
     width: 1280,
@@ -26,7 +31,6 @@ const LAUNCH_CONFIG_BY_ENV = {
     headless: true,
     slowMo: 100,
     devtools: true,
-    executablePath: "/opt/homebrew/bin/chromium",
     defaultViewport: {
       width: DEFAULT_LAUNCH_CONFIG.defaultViewport.width,
       height: DEFAULT_LAUNCH_CONFIG.defaultViewport.height + 560,