fingerprint gce: collect preemptibility

channable · Oct 23, 2024 · cdebf96 · cdebf96
1 parent cfba3ed
commit cdebf96
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/.changelog/24169.txt b/.changelog/24169.txt
@@ -0,0 +1,3 @@
+```release-note:improvement
+fingerprint gce: fingerprint preemptibility
+```
diff --git a/client/fingerprint/env_gce.go b/client/fingerprint/env_gce.go
@@ -160,6 +160,7 @@ func (f *EnvGCEFingerprint) Fingerprint(req *FingerprintRequest, resp *Fingerpri
 		"cpu-platform":                   false,
 		"scheduling/automatic-restart":   false,
 		"scheduling/on-host-maintenance": false,
+		"scheduling/preemptible":         false,
 	}
 
 	for k, unique := range keys {

diff --git a/client/fingerprint/env_gce_test.go b/client/fingerprint/env_gce_test.go
@@ -148,6 +148,7 @@ func testFingerprint_GCE(t *testing.T, withExternalIp bool) {
 
 	assertNodeAttributeEquals(t, response.Attributes, "platform.gce.scheduling.automatic-restart", "TRUE")
 	assertNodeAttributeEquals(t, response.Attributes, "platform.gce.scheduling.on-host-maintenance", "MIGRATE")
+	assertNodeAttributeEquals(t, response.Attributes, "platform.gce.scheduling.preemptible", "FALSE")
 	assertNodeAttributeEquals(t, response.Attributes, "platform.gce.cpu-platform", "Intel Ivy Bridge")
 	assertNodeAttributeEquals(t, response.Attributes, "platform.gce.tag.abc", "true")
 	assertNodeAttributeEquals(t, response.Attributes, "platform.gce.tag.def", "true")
@@ -200,6 +201,11 @@ const GCE_routes = `
       "content-type": "text/plain",
       "body": "MIGRATE"
     },
+    {
+      "uri": "/computeMetadata/v1/instance/scheduling/preemptible",
+      "content-type": "text/plain",
+      "body": "FALSE"
+    },
     {
       "uri": "/computeMetadata/v1/instance/cpu-platform",
       "content-type": "text/plain",