Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(weakpass): support caching_sha2_password and enhance MyISAM pkg #235

Merged
merged 1 commit into from
May 16, 2023
Merged

feat(weakpass): support caching_sha2_password and enhance MyISAM pkg #235

merged 1 commit into from
May 16, 2023

Conversation

asjdf
Copy link
Contributor

@asjdf asjdf commented May 6, 2023 •
edited
Loading

@asjdf asjdf mentioned this pull request May 6, 2023
Closed
@asjdf asjdf marked this pull request as draft May 10, 2023 16:19
@DVKunion
Copy link
Collaborator

DVKunion commented May 11, 2023 •
edited
Loading

整体上OK的，最后求能在ci的test中加一下mysql8的测试用例和压缩一下commit数量。

@asjdf
Copy link
Contributor Author

asjdf commented May 11, 2023

好的，正在处理冲突以及优化查询范围。等准备好merge后我会去除draft状态，届时还烦请您再次审阅。

@asjdf
Copy link
Contributor Author

asjdf commented May 12, 2023

MyISAM的解析那块似乎有一些问题，数据不是连续的，这两天正在检查。

@asjdf asjdf changed the title feat: support checking weakpass in MySQL8 feat(weakpass): support caching_sha2_password and enhance MyISAM pkg May 13, 2023
@asjdf
Copy link
Contributor Author

asjdf commented May 13, 2023

非常抱歉，由于这个分支中途merge过几次，导致不太方便/不太会压缩commit了，还请赐教x

适配问题已经较为丑陋的处理了一下，可能不太阳间。

@asjdf asjdf marked this pull request as ready for review May 13, 2023 20:08
@asjdf asjdf requested a review from DVKunion May 13, 2023 20:09
@DVKunion
Copy link
Collaborator

可以尝试先先rebase 主干的master分支，解决完rebase冲突后再试试压缩commit。

asjdf
asjdf commented May 15, 2023
View reviewed changes
Copy link
Contributor Author

@asjdf asjdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

手滑了x

plugins/go/veinmind-weakpass/service/mysql5.go Show resolved Hide resolved
@asjdf
feat(weakpass): support caching_sha2_password and enhance MyISAM pkg
65f2838 
feat(weakpass): better support for parsing MyISAM

feat(weakpass): support checking weakpass in MySQL8

update(weakpass): clear service
@DVKunion DVKunion merged commit 4d27100 into chaitin:master May 16, 2023
DVKunion pushed a commit to DVKunion/veinmind-tools that referenced this pull request May 23, 2023
@asjdf @DVKunion
feat(veinmind-weakpass): support caching_sha2_password and enhance My…
a21f9ff 
…ISAM pkg (chaitin#235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DVKunion DVKunion DVKunion left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asjdf @DVKunion