Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRODUCT-LIST] Add product list service for Activities #3

Merged
merged 2 commits into from
Dec 21, 2023
Merged

[PRODUCT-LIST] Add product list service for Activities #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
062e2a0
add activity product list
havan Dec 19, 2023
5d2c9c0
fix field in pickup dropoff event message
havan Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions proto/cmp/services/activity/v1alpha1/list.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
syntax = "proto3";

package cmp.services.activity.v1alpha1;

import "cmp/services/activity/v1alpha1/search_result_types.proto";
import "cmp/types/v1alpha1/common.proto";
import "google/protobuf/timestamp.proto";

message ActivityProductListRequest {
// Message header
cmp.types.v1alpha1.Header header = 1;

// Only respond with the products that are modified after this timestamp
google.protobuf.Timestamp modified_after = 2;
}

message ActivityProductListResponse {
// Message header
cmp.types.v1alpha1.Header header = 1;

// Product list: Activities
repeated Activity activities = 2;
}

// This service is used to get a product list for activities.
//
// ![Diagram](https://storage.googleapis.com/docs-cmp-files/diagrams/proto/cmp/services/activity/v1alpha1/list.proto.dot.xs.svg)
// [Open Message Diagram](https://storage.googleapis.com/docs-cmp-files/diagrams/proto/cmp/services/activity/v1alpha1/list.proto.dot.svg)
service ActivityProductListService {
// Gets an optional `modified_after` date and returns a product list.
rpc ActivityProductList(ActivityProductListRequest) returns (ActivityProductListResponse);
}
20 changes: 15 additions & 5 deletions proto/cmp/services/activity/v1alpha1/search_result_types.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ message ActivitySearchResult {
int32 result_id = 1;

// Activity basic info
ActivityInfo info = 2;
Activity info = 2;

// Schedule
cmp.types.v1alpha1.DateTimeRange schedule = 3;
Expand All @@ -45,10 +45,10 @@ message ActivitySearchResult {
PricingType pricing_type = 9;
}

// ### Activity Info
// Represents an Activity product.
//
// FIXME: We need optimizations in this type
message ActivityInfo {
message Activity {
// Ex: "TC000000"
string product_code = 1;

Expand Down Expand Up @@ -78,6 +78,12 @@ message ActivityInfo {

// Ex: "Safari"
string type_name = 10;

// Status
//
// FIXME: We need to make this an ENUM (this is also used for several other
// verticals)
string status = 11;
}

// ### Activity Location
Expand All @@ -99,8 +105,12 @@ message PickupDropoffEvent {
// Ex: "Sunny Beach Hotel",
string location_name = 2;

// Ex: "true",
bool pickup_ind = 3;
// True if this pickup location is selected for the activity
//
// Ex: "true"
//
// FIXME: How is this relevant for the search result message?
bool pickup_indicator = 3;

// Ex: "OTHERS / Parking Varadero(bus stop css nº50)",
string other_info = 4;
Expand Down