Make scheduler use lastExecutedAt instead of next planned executeAt #73
+148
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
evlekht
commented
Nov 26, 2024
•
evlekht
commented
- Improves scheduler initial timer code to support canceling by context.
- Modifies scheduled job: instead of next execution time, job now stores last execution time.
evlekht
force-pushed
the
evlekht/cash-in-schedule
branch
from
200cd6f
to
cc10514
Compare
evlekht
changed the title
havan
approved these changes
Nov 29, 2024
VjeraTurk
reviewed
Dec 3, 2024
Comment on lines
-167
to
+176
| executeAt := s.clock.Now().Add(period) | ||
|
|
||
| lastExecutedAt := time.Time{} | ||
| if job != nil { | ||
| job.Period = period | ||
| if executeAt.Before(job.ExecuteAt) { | ||
| job.ExecuteAt = executeAt | ||
| } | ||
| } else { | ||
| job = &Job{ | ||
| Name: jobName, | ||
| ExecuteAt: executeAt, | ||
| Period: period, | ||
| } | ||
| lastExecutedAt = job.LastExecutedAt |
There was a problem hiding this comment.
@evlekht please update comment on line 159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.