Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dbs path, fix db errors #62

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Fix dbs path, fix db errors #62

merged 4 commits into from
Oct 21, 2024

Conversation

evlekht
Copy link
Member

@evlekht evlekht commented Oct 21, 2024

#60 introduced some bugs with db config and db errors, this PR fixes that.

  • Storage should use its "user" package errors, because it depends on its interface. User-package expects certain errors defined by it, because it doesn't know about storage implementation.
  • DB pkg should ensure database path, otherwise it would fail if path is missing some folders along the way.
  • matrix.storage config field could be removed in favor of general db.path that defines database root directory

@evlekht evlekht marked this pull request as ready for review October 21, 2024 12:57
@evlekht evlekht merged commit 4fe2ca6 into dev Oct 21, 2024
3 checks passed
@evlekht evlekht deleted the evlekht/fixes branch October 21, 2024 14:24
nkoljanin pushed a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants