Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cheque and matrix-message types and signing #28

Merged
merged 8 commits into from
Sep 20, 2024
Merged

Cheque and matrix-message types and signing #28

merged 8 commits into from
Sep 20, 2024

Conversation

evlekht
Copy link
Member

@evlekht evlekht commented Sep 18, 2024 •
edited
Loading

PR introduces cheques primitives that will be used by bot and app service.

  • Moves CaminoMatrixMessage type and some common matrix initialization from internal to pkg, because it will be imported by other module (ASB) as well.
  • Adds pkg/cheques package with signed and unsigned cheque types and signer type that does EIP712 signing.
  • Changes message Metadata.Cheques type from []map[string]any to strictly typed []*SignedCheque

@evlekht evlekht changed the title Evlekht/cheques Cheque and matrix-message types and signing Sep 19, 2024
@evlekht evlekht force-pushed the evlekht/cheques branch 2 times, most recently from 2296386 to 19da66d Compare September 19, 2024 13:46
@evlekht evlekht marked this pull request as ready for review September 19, 2024 14:05
havan
havan approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@havan havan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evlekht evlekht merged commit b8d11b9 into dev Sep 20, 2024
3 checks passed
@evlekht evlekht deleted the evlekht/cheques branch September 20, 2024 04:58
evlekht added a commit that referenced this pull request Sep 29, 2024
@evlekht
Matrix-message types and cheque signing (#28)
720f34c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havan havan havan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evlekht @havan