fix: Added Obj-C support check in generated bundle header files #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krypt-lx
changed the title
cgrindel
approved these changes
Apr 8, 2024
renovate bot
referenced
this pull request
in bazel-contrib/rules_bazel_integration_test
Apr 11, 2024
…#302) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | rules_swift_package_manager | bazel_dep | patch | `0.29.1` -> `0.29.2` | | [rules_swift_package_manager](https://togithub.com/cgrindel/rules_swift_package_manager) | http_archive | patch | `v0.29.1` -> `v0.29.2` | --- ### Release Notes <details> <summary>cgrindel/rules_swift_package_manager (rules_swift_package_manager)</summary> ### [`v0.29.2`](https://togithub.com/cgrindel/rules_swift_package_manager/releases/tag/v0.29.2) [Compare Source](https://togithub.com/cgrindel/rules_swift_package_manager/compare/v0.29.1...v0.29.2) #### What's Changed - chore: update README.md for v0.29.1 by [@​cgrindel-app-token-generator](https://togithub.com/cgrindel-app-token-generator) in [https://github.com/cgrindel/rules_swift_package_manager/pull/979](https://togithub.com/cgrindel/rules_swift_package_manager/pull/979) - chore(deps): update dependency rules_swift to v1.17.0 by [@​cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate) in [https://github.com/cgrindel/rules_swift_package_manager/pull/973](https://togithub.com/cgrindel/rules_swift_package_manager/pull/973) - chore(deps): update dependency cgrindel_bazel_starlib to v0.20.2 by [@​cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate) in [https://github.com/cgrindel/rules_swift_package_manager/pull/974](https://togithub.com/cgrindel/rules_swift_package_manager/pull/974) - chore(deps): update dependency quick/quick to from: "7.5.0" by [@​cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate) in [https://github.com/cgrindel/rules_swift_package_manager/pull/980](https://togithub.com/cgrindel/rules_swift_package_manager/pull/980) - chore(deps): update dependency marmelroy/phonenumberkit to from: "3.7.10" by [@​cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate) in [https://github.com/cgrindel/rules_swift_package_manager/pull/981](https://togithub.com/cgrindel/rules_swift_package_manager/pull/981) - feat: Support netrc authentication by [@​jflan-dd](https://togithub.com/jflan-dd) in [https://github.com/cgrindel/rules_swift_package_manager/pull/982](https://togithub.com/cgrindel/rules_swift_package_manager/pull/982) - chore(deps): update dependency sdwebimage/sdwebimageswiftui to from: "3.0.2" by [@​cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate) in [https://github.com/cgrindel/rules_swift_package_manager/pull/986](https://togithub.com/cgrindel/rules_swift_package_manager/pull/986) - chore(deps): update dependency rules_apple to v3.4.0 by [@​cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate) in [https://github.com/cgrindel/rules_swift_package_manager/pull/988](https://togithub.com/cgrindel/rules_swift_package_manager/pull/988) - fix(deps): update module github.com/stretchr/testify to v1.9.0 by [@​cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate) in [https://github.com/cgrindel/rules_swift_package_manager/pull/943](https://togithub.com/cgrindel/rules_swift_package_manager/pull/943) - chore(deps): update dependency apple_support to v1.15.1 by [@​cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate) in [https://github.com/cgrindel/rules_swift_package_manager/pull/989](https://togithub.com/cgrindel/rules_swift_package_manager/pull/989) - chore(deps): update dependency google/googlesignin-ios to from: "7.1.0" by [@​cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate) in [https://github.com/cgrindel/rules_swift_package_manager/pull/984](https://togithub.com/cgrindel/rules_swift_package_manager/pull/984) - chore(deps): update dependency bazel_gazelle to v0.36.0 by [@​cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate) in [https://github.com/cgrindel/rules_swift_package_manager/pull/990](https://togithub.com/cgrindel/rules_swift_package_manager/pull/990) - chore(deps): update dependency gazelle to v0.36.0 by [@​cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate) in [https://github.com/cgrindel/rules_swift_package_manager/pull/991](https://togithub.com/cgrindel/rules_swift_package_manager/pull/991) - chore(deps): update dependency rules_xcodeproj to v2 by [@​cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate) in [https://github.com/cgrindel/rules_swift_package_manager/pull/993](https://togithub.com/cgrindel/rules_swift_package_manager/pull/993) - chore(deps): update dependency airbnb/lottie-spm to from: "4.4.2" by [@​cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate) in [https://github.com/cgrindel/rules_swift_package_manager/pull/994](https://togithub.com/cgrindel/rules_swift_package_manager/pull/994) - fix: Added Obj-C support check in generated bundle header files by [@​krypt-lx](https://togithub.com/krypt-lx) in [https://github.com/cgrindel/rules_swift_package_manager/pull/999](https://togithub.com/cgrindel/rules_swift_package_manager/pull/999) - chore(deps): update dependency build_bazel_rules_swift to v1.18.0 by [@​cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate) in [https://github.com/cgrindel/rules_swift_package_manager/pull/995](https://togithub.com/cgrindel/rules_swift_package_manager/pull/995) - chore(deps): update dependency firebase/firebase-ios-sdk to from: "10.23.1" by [@​cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate) in [https://github.com/cgrindel/rules_swift_package_manager/pull/948](https://togithub.com/cgrindel/rules_swift_package_manager/pull/948) - chore(deps): update dependency rules_apple to v3.5.0 by [@​cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate) in [https://github.com/cgrindel/rules_swift_package_manager/pull/996](https://togithub.com/cgrindel/rules_swift_package_manager/pull/996) - chore(deps): update dependency rules_swift to v1.18.0 by [@​cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate) in [https://github.com/cgrindel/rules_swift_package_manager/pull/997](https://togithub.com/cgrindel/rules_swift_package_manager/pull/997) #### New Contributors - [@​jflan-dd](https://togithub.com/jflan-dd) made their first contribution in [https://github.com/cgrindel/rules_swift_package_manager/pull/982](https://togithub.com/cgrindel/rules_swift_package_manager/pull/982) - [@​krypt-lx](https://togithub.com/krypt-lx) made their first contribution in [https://github.com/cgrindel/rules_swift_package_manager/pull/999](https://togithub.com/cgrindel/rules_swift_package_manager/pull/999) **Full Changelog**: cgrindel/rules_swift_package_manager@v0.29.1...v0.29.2 #### Bazel Module Snippet ```python bazel_dep(name = "rules_swift_package_manager", version = "0.29.2") ``` #### Workspace Snippet ```python load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "rules_swift_package_manager", sha256 = "b60a02e75b1cffce6951a992b9d389a51cbbd98f190e507b625a8eeb70b4def5", urls = [ "https://github.com/cgrindel/rules_swift_package_manager/releases/download/v0.29.2/rules_swift_package_manager.v0.29.2.tar.gz", ], ) load("@​rules_swift_package_manager//:deps.bzl", "swift_bazel_dependencies") swift_bazel_dependencies() load("@​cgrindel_bazel_starlib//:deps.bzl", "bazel_starlib_dependencies") bazel_starlib_dependencies() ### MARK: - Gazelle ### gazelle:repo bazel_gazelle load("@​bazel_gazelle//:deps.bzl", "gazelle_dependencies") load("@​rules_swift_package_manager//:go_deps.bzl", "swift_bazel_go_dependencies") load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") ### Declare Go dependencies before calling go_rules_dependencies. swift_bazel_go_dependencies() go_rules_dependencies() go_register_toolchains(version = "1.21.1") gazelle_dependencies() ### MARK: - Swift Toolchain http_archive( name = "build_bazel_rules_swift", ### Populate with your preferred release ### https://github.com/bazelbuild/rules_swift/releases ) load( "@​build_bazel_rules_swift//swift:repositories.bzl", "swift_rules_dependencies", ) load("//:swift_deps.bzl", "swift_dependencies") ### gazelle:repository_macro swift_deps.bzl%swift_dependencies swift_dependencies() swift_rules_dependencies() load( "@​build_bazel_rules_swift//swift:extras.bzl", "swift_rules_extra_dependencies", ) swift_rules_extra_dependencies() ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/bazel-contrib/rules_bazel_integration_test). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds check for presence of ObjC support in currently used compiler. If not, skips SWIFTPM_MODULE_BUNDLE macros altogether.
fixes #998