Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure the xcodeproj project generation uses the correct Bazel binary in the firebase_example #1401

Merged
merged 9 commits into from
Dec 16, 2024

Conversation

cgrindel
Copy link
Owner

@cgrindel cgrindel commented Dec 14, 2024

The rules_xcodeproj project generator calls Bazel. By default, it looks for bazel on the PATH. When running under rules_bazel_integration_test this will pick up the default Bazel version on the system. If that is Bazelisk, it will pull down the latest Bazel. The fix is to explicitly tell xcodeproj which Bazel binary to use.

  • Add tools/bazel to the firebase_example. It inspects environment variables to determine the Bazel version to use and writes tools/bazel_for_xcodeproj which executes Bazel commands against the correct Bazel binary.
  • Use sanbox for rules_xcodeproj builds in firebase example. This avoids the duplicate definition error.
  • Add print_and_run bash function to examples/firebase_example/do_test to ease debugging future issues.

@cgrindel cgrindel self-assigned this Dec 14, 2024
@cgrindel cgrindel marked this pull request as ready for review December 14, 2024 20:56
@cgrindel cgrindel enabled auto-merge (squash) December 14, 2024 21:05
@cgrindel cgrindel merged commit 64e6609 into main Dec 16, 2024
32 checks passed
@cgrindel cgrindel deleted the fix_failing_firebase_example branch December 16, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants