Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for systemLibrary targets #1323

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add support for systemLibrary targets #1323

wants to merge 1 commit into from

Conversation

lucasmarcal-faire
Copy link
Contributor

@lucasmarcal-faire lucasmarcal-faire commented Nov 5, 2024 •
edited by luispadron
Loading

Fixes #248

@lucasmarcal-faire lucasmarcal-faire mentioned this pull request Nov 5, 2024
Open
@cgrindel
Copy link
Owner

cgrindel commented Nov 6, 2024

@lucasmarcal-faire LGTM so far. I have two requests:

  1. Can you add a Swift package that has system libraries to one of the examples?
  2. Can you add a target generation unit test?

Thank you for your efforts on this! It is greatly appreciated.

@luispadron luispadron changed the title draft: Add support to SPM SystemLibrary feat: add support to systemLibrary targets Nov 12, 2024
@luispadron luispadron changed the title feat: add support to systemLibrary targets feat: add support for systemLibrary targets Nov 12, 2024
@luispadron
Copy link
Collaborator

@lucasmarcal-faire Any plans to pick this back up? Thanks again for getting the work started here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support system target types
3 participants
@lucasmarcal-faire @cgrindel @luispadron