This repository has been archived by the owner on May 6, 2020. It is now read-only.
Netty 4 Alpha has removed org.jboss from packages #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netty 4 has removed org.jboss from all the packages, plus it has included the websocket handshakers and client from Netty Tools (with some minor modifications). The changes should be backward compatible, however, some of the netty-tools classes are now obsolete (and may not work with Netty 4's decoders) because they are included in netty directly. Additionally, I updated the pom for the Alpha snapshot dependency. I'm not sure if that library exists in external or jboss repos, as I just compiled and installed the Netty libs into my local maven repo directly. I was able to basically replace all of my websocket handling with the Netty 4 versions and use netty-tools for just the RouterHandler.