Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCCP: Improve eligibility content #8515

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

niqjohnson
Copy link
Member

Refine content about card eligibility to be as specific as we can.


Additions

  • geographic_restrictions and professional_affiliation to CardSurveyDataListSerializer so they're available to tooltips in the card list
  • A phrase at the end of the generic credit union eligibility requirement noting some common credit union membership requirements

Changes

  • Eligibility tooltips now use a few fields to tailor the content for each card

How to test this PR

  1. Make sure the eligibility tooltip content looks like the screenshots below and matches the requirements called out on the details page
  2. Make sure the generic credit union eligibility requirement on the details page now ends with the phrase, "which typically include living in certain areas or working for certain employers."

Screenshots

Credit union, no requirements in data Credit union, one requirement in data Credit union, two requirements in data Bank, one requirement in data Details
tooltip-cu-no-reqs tooltip-cu-geo tooltip-cu-geo-prof tooltip-bank-geo details

Notes and todos

  • Depending on how these changes tests, we might make a few more tweaks to the tooltip content or logic (see GHE/Design-Development/Design-Thinking-and-User-Research/issues/339 for more)

Checklist

  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • Consider prefixing, e.g., "Mega Menu: fix layout bug", or "Docs: Update Docker installation instructions".
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines

@niqjohnson niqjohnson requested review from chosak and contolini July 17, 2024 16:26
Copy link
Member

@chosak chosak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised!

@niqjohnson niqjohnson added this pull request to the merge queue Jul 17, 2024
{{ tooltip(
name='apr-disclaimer',
heading=(
'Check with the company for eligibility requirements.'
'You must '
~ ('be a member of this credit union' if card.issued_by_credit_union else 'meet requirements set by the bank')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space:

Suggested change
~ ('be a member of this credit union' if card.issued_by_credit_union else 'meet requirements set by the bank')
~ ('be a member of this credit union' if card.issued_by_credit_union else 'meet requirements set by the bank')

Merged via the queue into main with commit 25f3508 Jul 17, 2024
12 checks passed
@niqjohnson niqjohnson deleted the tccp/eligibility-tooltip branch July 17, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants