-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Less to Sass #8514
Convert Less to Sass #8514
Conversation
b6adba5
to
445e41c
Compare
8f3c727
to
aacae5e
Compare
8b0a901
to
0f63b25
Compare
$tint: #{$value}-bg; | ||
$light: #{$value}-lt; | ||
$med: #{$value}-md; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to read from colors map:
$tint: #{$value}-bg; | |
$light: #{$value}-lt; | |
$med: #{$value}-md; | |
$tint: map.get($colors-map, #{$value}-bg); | |
$light: map.get($colors-map, #{$value}-lt); | |
$med: map.get($colors-map, #{$value}-md); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Re: our chat about system-ui
, I've noticed that some of our apps (TCCP, find a housing counselor) are prioritizing system-ui
over Avenir Next
, causing the font to be slightly different. Not sure why but something to be aware of.
This seems like it's because Avenir is only defined in cfpb-typography, vs. I imagine that sass is choking on it in a way that a less Perhaps |
880b343
to
8a1c26e
Compare
8a1c26e
to
054a092
Compare
Updated to v3 DS. Try it now. Thanks! |
EDIT: fixed it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests and looks great!
9873e3d
to
9c7e420
Compare
Changes
How to test this PR
yarn install && yarn build
and site should be unchanged.