Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCCP: Fix phone number parsing #8505

Merged
merged 1 commit into from
Jul 10, 2024
Merged

TCCP: Fix phone number parsing #8505

merged 1 commit into from
Jul 10, 2024

Conversation

chosak
Copy link
Member

@chosak chosak commented Jul 10, 2024

This commit modifies how phone numbers are rendered on the frontend of the "Explore credit cards" tool. It fixes an issue with parsing phone numbers that have spaces in them in the TCCP dataset. The TCCP dataset contains cards that only provide a single phone number, but sometimes this can include spaces, for example:

1 (800) 555-1234

Instead of parsing this like multiple phone numbers separated by spaces, we need to parse this as a single phone number.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines

This commit modifies how phone numbers are rendered on the frontend of
the "Explore credit cards" tool. It fixes an issue with parsing phone
numbers that have spaces in them in the TCCP dataset. The TCCP dataset
contains cards that only provide a single phone number, but sometimes
this can include spaces, for example:

1 (800) 555-1234

Instead of parsing this like multiple phone numbers separated by spaces,
we need to parse this as a single phone number.
Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodbye spaces 👋

@chosak chosak added this pull request to the merge queue Jul 10, 2024
Merged via the queue into main with commit 000011a Jul 10, 2024
12 checks passed
@chosak chosak deleted the tccp/fix-phone-numbers branch July 10, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants