Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCCP: Dataset format updates #8499

Merged
merged 1 commit into from
Jul 9, 2024
Merged

TCCP: Dataset format updates #8499

merged 1 commit into from
Jul 9, 2024

Conversation

chosak
Copy link
Member

@chosak chosak commented Jul 8, 2024

This PR adds 4 new fields to the TCCP CardSurveyData model: advance_apr_no_score, intro_apr_no_score, purchase_apr_no_score, and transfer_apr_no_score. These fields hold information on APRs available to consumers with no credit score. These fields are optional in the dataset and are not used in the "Explore credit cards" tool anywhere.

This PR also renames the top_25_institution column to issued_by_top_25_institution for clarity.

How to test this PR

There should be no user-visible changes.

If you run a local server and load the forthcoming dataset (ask me), the "Small institution" checkbox should continue to work properly.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines

This commit adds 4 new fields to the TCCP CardSurveyData model:
advance_apr_no_score, intro_apr_no_score, purchase_apr_no_score, and
transfer_apr_no_score. These fields hold information on APRs available
to consumers with no credit score. These fields are optional in the
dataset and are not used in the "Explore credit cards" tool anywhere.

This commit also renames the top_25_institution column to
issued_by_top_25_institution for clarity.
Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let 'er rip

@chosak chosak added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit e6fc558 Jul 9, 2024
12 checks passed
@chosak chosak deleted the tccp/apr-no-score branch July 9, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants