TDP: hardcode TdpSearchHeroImage
#8277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anselmbradford
force-pushed
the
ans_hardcode_tdp_hero
branch
from
9219251 to
660432f
Compare
willbarton
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TDP has a
TdpSearchHeroImagein Wagtail for setting the large and small hero image on https://www.consumerfinance.gov/consumer-tools/educator-tools/youth-financial-education/teach/activities/In the history of that page, it doesn't appear we've ever changed the image. It seems like it would remove some Wagtail cruft to just hardcode the hero image. It can still be updated by updating the URLs in the template.
Also, the image didn't have an
altvalue, and this PR adds one.Removals
TdpSearchHeroImageHow to test this PR
python cfgov/manage.py migrateand visit http://localhost:8000/consumer-tools/educator-tools/youth-financial-education/teach/activities/ and compare to production and see that the hero image is unchanged.