TCCP: Exclude non-targeted cards #8262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Placing this on hold pending further internal discussion. |
Some credit cards offer a purchase APR for a specific credit tier but are not marked as being "specifically targeted" to that credit tier, recorded in the TCCP survey under the "Targeted credit tiers" column. Previously TCCP filter results would include these cards, so if a user marked their credit tier as 620-719, they might see cards that, while they offer a purchase APR for this range, are not marked as being "specifically targeted" to this range. This change removes those cards from the results.
chosak
force-pushed
the
tccp/filter-nontargeted-tiers
branch
from
fb8697a to
bee2c46
Compare
|
Removing hold label as we have settled on new purchase APR logic that will include this change. @contolini @niqjohnson |
|
Closing in favor of #8285, which includes the commit here as well as other purchase APR logic changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some credit cards offer a purchase APR for a specific credit tier but are not marked as being "specifically targeted" to that credit tier, recorded in the TCCP survey under the "Targeted credit tiers" column.
Previously TCCP filter results would include these cards, so if a user marked their credit tier as 620-719, they might see cards that, while they offer a purchase APR for this range, are not marked as being "specifically targeted" to this range.
This change removes those cards from the results.
How to test this PR
The easiest way to do this is to do a search and see what doesn't show up in the results. Run a local server and visit this link. That link shows cards for the "good" tier in DC, ordered by card name. You'll see that this card doesn't show up, even though it is available in that location and has a purchase APR for the good tier.
Checklist