Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove content-l__main class #8228

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Remove content-l__main class #8228

merged 5 commits into from
Mar 21, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Mar 14, 2024

The corresponding removal of this class in the DS is happening in cfpb/design-system#1929

Removals

  • Remove content-l__main class

How to test this PR

  1. yarn build and visit the newsroom. Check the pre-footer and resize the page. With this change the stacking of the items in the pre-footer changes orientation in the tablet range for the page.

Screenshots

Before:
Screenshot 2024-03-14 at 2 08 45 PM

After:
Screenshot 2024-03-14 at 2 08 54 PM

@anselmbradford anselmbradford changed the title Remove content-li__main class Remove content-l__main class Mar 14, 2024
@anselmbradford anselmbradford force-pushed the ans_remove_content_main branch from 44b14cb to f576fdd Compare March 14, 2024 18:13
@anselmbradford
Copy link
Member Author

Bumped to design-system 0.40.0 to remove classes cfpb/design-system@v0.39.0...v0.40.0

@wpears
Copy link
Member

wpears commented Mar 21, 2024

@anselmbradford Looks like you'll need to redefine grid_column__top-divider in cfgov/unprocessed/css/organisms/info-unit-group.less

@anselmbradford
Copy link
Member Author

@anselmbradford Looks like you'll need to redefine grid_column__top-divider in cfgov/unprocessed/css/organisms/info-unit-group.less

Yeah merging in #8232 and I'll rebase here

@anselmbradford anselmbradford added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit 5652238 Mar 21, 2024
18 checks passed
@anselmbradford anselmbradford deleted the ans_remove_content_main branch March 21, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants