Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate 3 unused Django settings #8056

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

chosak
Copy link
Member

@chosak chosak commented Dec 8, 2023

This commit deprecates 3 unused Django settings:

OFFLINE_OUTPUT_DIR = ''
GOOGLE_ANALYTICS_ID = ''
GOOGLE_ANALYTICS_SITE = ''

These were all added back in April 2016 (in commit b859cc8) but as far as I can tell are not used anywhere. Therefore we can remove them.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines

This commit deprecates 3 unused Django settings:

OFFLINE_OUTPUT_DIR = ''
GOOGLE_ANALYTICS_ID = ''
GOOGLE_ANALYTICS_SITE = ''

These were all added back in April 2016 (!) but as far as I can tell
are not used anywhere. Therefore we can remove them.
@anselmbradford
Copy link
Member

Maybe intended for #495 ? Would it make any sense to use the Google variables versus removing them?

@chosak
Copy link
Member Author

chosak commented Dec 8, 2023

@anselmbradford definitely a good idea! Since we have that issue open as a place to track it, though, I'd prefer to delete for now and re-add when we pick that back up.

If it's the case (as it seems to be?) that we're using the same Google ID in the base.html template and so every page in every cf.gov request -- production, beta, internal, even local development? -- record that traffic to the same GA account.. and that's been happening since you opened #495 in 2015? that seems like a bigger problem. Pinging @sonnakim for awareness.

@chosak chosak added this pull request to the merge queue Dec 8, 2023
Merged via the queue into main with commit e186443 Dec 8, 2023
11 checks passed
@chosak chosak deleted the deprecate/unused-settings branch December 8, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants