CFE-4453: Added missing trailing slash to .no-distrib directory in MPF #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this has no functional difference, but it's an important hint at least to the policy reader that it is a directory. Unlike other access rules I left off the condition to only add the access rule if the directory exists so that if it is created there will not be a window of time for which clients would be able to get files from the directory. If the directory does not exist there are info level logs that are emitted, but that seems acceptable since we do not log info from cf-serverd by default. There is apparently no issue making an access promise for a directory that does not exist, I see it listed in the cf-serverd access summary from verbose logging. Ticket: CFE-4453 Changelog: None
olehermanse
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this has no functional difference, but it's an important hint at least
to the policy reader that it is a directory.
Unlike other access rules I left off the condition to only add the access rule
if the directory exists so that if it is created there will not be a window of
time for which clients would be able to get files from the directory.
If the directory does not exist there are info level logs that are emitted, but
that seems acceptable since we do not log info from cf-serverd by default. There
is apparently no issue making an access promise for a directory that does not
exist, I see it listed in the cf-serverd access summary from verbose logging.
Ticket: CFE-4453
Changelog: None